1. Forum
  2. FidoNet
  3. MAKENL NG

  • illegal character

    From andrew clarke@3:633/267 to Andrew Leary on Mon May 17 19:42:59 2021
    commit b62afadb35d6c8f334872713a9c3aa91cec42d7c (HEAD -> master, origin/master, origin/HEAD)
    Author: Andrew Leary <ajleary19@gmail.com>
    Date: Mon May 17 00:58:31 2021 -0400

    Correct spelling of Bj<94>rn Felten's name in the credits and manpage.


    I don't believe this was broken, and now clang complains about your fix:

    [ 5%] Building C object CMakeFiles/makenl.dir/config.c.o /home/ozzmosis/src/makenl/src/config.c:243:12: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    printf(MAKENL_CREDITS);
    ^~~~~~~~~~~~~~
    /home/ozzmosis/src/makenl/src/version.h:26:23: note: expanded from macro 'MAKENL_CREDITS'
    "modifications by Bj<94>rn Felten, Robert Couture, Andrew Clarke," "\n" \
    ^~~~
    1 warning generated.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Andrew Leary@1:320/219 to andrew clarke on Mon May 17 08:59:58 2021
    Hello andrew!

    17 May 21 19:42, you wrote to me:

    commit b62afadb35d6c8f334872713a9c3aa91cec42d7c (HEAD -> master, origin/master, origin/HEAD)
    Author: Andrew Leary <ajleary19@gmail.com>
    Date: Mon May 17 00:58:31 2021 -0400

    Correct spelling of Bj<94>rn Felten's name in the credits and
    manpage.

    I don't believe this was broken, and now clang complains about your
    fix:

    [ 5%] Building C object CMakeFiles/makenl.dir/config.c.o /home/ozzmosis/src/makenl/src/config.c:243:12: warning: illegal
    character encoding in string literal [-Winvalid-source-encoding]
    printf(MAKENL_CREDITS);
    ^~~~~~~~~~~~~~
    /home/ozzmosis/src/makenl/src/version.h:26:23: note: expanded from
    macro 'MAKENL_CREDITS' "modifications by Bj<94>rn Felten, Robert
    Couture, Andrew Clarke," "\n" \
    ^~~~
    1 warning generated.

    Bjorn Felten netmailed me requesting that the UTF-8 representation of the character that previously was in version.h be replaced; because it doesn't display properly in DOS or Windows environments. GCC had no issue with it when I tested compiling here. If clang doesn't like it, I can adjust to avoid that issue.

    Andrew

    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)
  • From andrew clarke@3:633/267 to Andrew Leary on Tue May 18 01:01:09 2021
    On 2021-05-17 08:59:58, Andrew Leary (1:320/219) wrote to andrew clarke:

    Bjorn Felten netmailed me requesting that the UTF-8 representation of
    the character that previously was in version.h be replaced; because it doesn't display properly in DOS or Windows environments. GCC had no
    issue with it when I tested compiling here. If clang doesn't like it, I can adjust to avoid that issue.

    Your change broke the output on all systems that use UTF-8. Fixed.
    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)